steel_core/behavior/blocks/fluid/

liquid_block.rs

//! Liquid block behavior (water, lava).
//!
//! Based on vanilla's LiquidBlock.java.
use std::sync::Arc;

use steel_macros::block_behavior;
use steel_registry::REGISTRY;
use steel_registry::blocks::BlockRef;
use steel_registry::blocks::block_state_ext::BlockStateExt;
use steel_registry::blocks::properties::{BlockStateProperties, Direction};
use steel_registry::fluid::FluidRef;
use steel_registry::item_stack::ItemStack;
use steel_registry::vanilla_block_tags::BlockTag;
use steel_registry::vanilla_blocks;
use steel_registry::vanilla_fluid_tags::FluidTag;
use steel_utils::BlockPos;
use steel_utils::BlockStateId;
use steel_utils::types::UpdateFlags;

use steel_registry::level_events;
use steel_registry::sound_events;
use steel_registry::vanilla_items;

use crate::behavior::FLUID_BEHAVIORS;
use crate::behavior::block::{BlockBehavior, PickupResult};
use crate::behavior::context::BlockPlaceContext;
use crate::entity::ai::path::PathComputationType;
use crate::fluid::{FluidStateExt, is_lava_fluid, is_water_fluid};
use crate::player::Player;
use crate::world::{ConditionalBlockSetResult, ScheduledTickAccess, World};

use super::BubbleColumnBlock;

/// Behavior for liquid blocks (water and lava).
///
/// Liquid blocks have a LEVEL property (0-15) that determines the fluid state:
/// - LEVEL 0 = source block (full fluid)
/// - LEVEL 1-7 = flowing fluid with decreasing height
/// - LEVEL 8-15 = falling fluid
#[block_behavior]
pub struct LiquidBlock {
    block: BlockRef,
    #[json_arg(vanilla_fluids, ref)]
    fluid: FluidRef,
}

impl LiquidBlock {
    /// Creates a new liquid block behavior.
    #[must_use]
    pub const fn new(block: BlockRef, fluid: FluidRef) -> Self {
        Self { block, fluid }
    }

    /// Checks if this liquid should spread and handles lava-water interactions.
    /// Based on vanilla's `LiquidBlock.shouldSpreadLiquid()`.
    ///
    /// Returns `true` if the liquid should spread (schedule tick),
    /// Returns `false` if the liquid was converted to a block (obsidian/cobblestone/basalt).
    fn should_spread_liquid(&self, world: &Arc<World>, pos: BlockPos) -> bool {
        // Only lava has special interactions with water and blue ice
        if !is_lava_fluid(self.fluid) {
            return true;
        }
        // Check if there's soul soil below (for basalt generation)
        let below_pos = pos.offset(0, -1, 0);
        let below_state = world.get_block_state(below_pos);
        let has_soul_soil_below = below_state.get_block() == &vanilla_blocks::SOUL_SOIL;

        // Get fluid state to check if this is a source
        let fluid_state = world.get_block_state(pos).get_fluid_state();

        for direction in Direction::FLOW_NEIGHBOR_CHECK {
            let neighbor_pos = direction.relative(pos);
            let neighbor_fluid = world.get_block_state(neighbor_pos).get_fluid_state();

            // Check for water (including flowing_water and waterlogged blocks)
            // Using fluid tag check to support modded fluids registered in the water tag
            if neighbor_fluid.is_water() {
                // Lava + Water = Obsidian (if source) or Cobblestone (if flowing)
                let new_block = if fluid_state.is_source() {
                    &vanilla_blocks::OBSIDIAN
                } else {
                    &vanilla_blocks::COBBLESTONE
                };

                let new_state = REGISTRY.blocks.get_default_state_id(new_block);
                world.set_block(pos, new_state, UpdateFlags::UPDATE_ALL);
                world.level_event(level_events::LAVA_FIZZ, pos, 0, None);
                return false; // Don't schedule fluid tick - block was converted
            }

            // Check for basalt generation: soul soil below + blue ice adjacent
            if has_soul_soil_below {
                let neighbor_state = world.get_block_state(neighbor_pos);
                if neighbor_state.get_block() == &vanilla_blocks::BLUE_ICE {
                    let new_state = REGISTRY
                        .blocks
                        .get_default_state_id(&vanilla_blocks::BASALT);
                    world.set_block(pos, new_state, UpdateFlags::UPDATE_ALL);
                    world.level_event(level_events::LAVA_FIZZ, pos, 0, None);
                    return false; // Don't schedule fluid tick - block was converted
                }
            }
        }

        true // No interaction occurred, proceed with normal fluid tick
    }

    fn should_bubble_column_occupy(state: BlockStateId) -> bool {
        let fluid_state = state.get_fluid_state();
        fluid_state
            .fluid_id
            .has_tag(&FluidTag::BUBBLE_COLUMN_CAN_OCCUPY)
            && fluid_state.is_source()
            && fluid_state.amount >= 8
    }

    fn try_schedule_bubble_block_column(
        &self,
        ticks: &dyn ScheduledTickAccess,
        pos: BlockPos,
        state_below: BlockStateId,
    ) {
        let block_below = state_below.get_block();
        if block_below.has_tag(&BlockTag::ENABLES_BUBBLE_COLUMN_DRAG_DOWN)
            || block_below.has_tag(&BlockTag::ENABLES_BUBBLE_COLUMN_PUSH_UP)
        {
            let _ = ticks.schedule_block_tick_default(pos, self.block, 20);
        }
    }
}

impl BlockBehavior for LiquidBlock {
    fn get_state_for_placement(&self, _context: &BlockPlaceContext<'_>) -> Option<BlockStateId> {
        Some(self.block.default_state())
    }

    fn is_pathfindable(
        &self,
        _state: BlockStateId,
        _computation_type: PathComputationType,
    ) -> bool {
        !is_lava_fluid(self.fluid)
    }

    /// Called when the block is placed.
    fn on_place(
        &self,
        state: BlockStateId,
        world: &Arc<World>,
        pos: BlockPos,
        _old_state: BlockStateId,
        _moved_by_piston: bool,
    ) {
        if self.should_spread_liquid(world, pos) {
            let fluid = state.get_fluid_state().fluid_id;
            let delay = FLUID_BEHAVIORS.get_behavior(fluid).tick_delay(world);
            world.schedule_fluid_tick_default(pos, fluid, delay);
        }

        if Self::should_bubble_column_occupy(state) {
            self.try_schedule_bubble_block_column(world, pos, world.get_block_state(pos.below()));
        }
    }

    fn tick(&self, state: BlockStateId, world: &Arc<World>, pos: BlockPos) {
        if Self::should_bubble_column_occupy(state) {
            BubbleColumnBlock::update_column(
                &vanilla_blocks::BUBBLE_COLUMN,
                world,
                pos,
                world.get_block_state(pos.below()),
            );
        }
    }

    /// Called when a neighboring block changes.
    fn handle_neighbor_changed(
        &self,
        state: BlockStateId,
        world: &Arc<World>,
        pos: BlockPos,
        _source_block: BlockRef,
        _moved_by_piston: bool,
    ) {
        if self.should_spread_liquid(world, pos) {
            let fluid = world.get_block_state(pos).get_fluid_state().fluid_id;
            let delay = FLUID_BEHAVIORS.get_behavior(fluid).tick_delay(world);
            world.schedule_fluid_tick_default(pos, fluid, delay);
        }

        if Self::should_bubble_column_occupy(state) {
            self.try_schedule_bubble_block_column(world, pos, world.get_block_state(pos.below()));
        }
    }

    /// Called when a neighbor's shape changes.
    ///
    /// Vanilla parity: `LiquidBlock.updateShape` schedules a tick only when
    /// either the current block or the neighbor contains a source fluid.
    fn update_shape(
        &self,
        state: BlockStateId,
        world: &dyn ScheduledTickAccess,
        pos: BlockPos,
        direction: Direction,
        _neighbor_pos: BlockPos,
        neighbor_state: BlockStateId,
    ) -> BlockStateId {
        let fluid_state = state.get_fluid_state();
        let neighbor_fluid = neighbor_state.get_fluid_state();

        if fluid_state.is_source() || neighbor_fluid.is_source() {
            let delay = world.fluid_tick_delay(fluid_state.fluid_id);
            world.schedule_fluid_tick_default(pos, fluid_state.fluid_id, delay);
        }

        if direction == Direction::Down && Self::should_bubble_column_occupy(state) {
            self.try_schedule_bubble_block_column(world, pos, neighbor_state);
        }

        state
    }

    /// Vanilla parity: `LiquidBlock.randomTick` delegates to the fluid.
    fn random_tick(&self, state: BlockStateId, world: &Arc<World>, pos: BlockPos) {
        FLUID_BEHAVIORS
            .get_behavior(state.get_fluid_state().fluid_id)
            .random_tick(world, pos);
    }

    fn pickup_block(
        &self,
        world: &Arc<World>,
        pos: BlockPos,
        state: BlockStateId,
        _player: Option<&Player>,
    ) -> Option<PickupResult> {
        if state.try_get_value(&BlockStateProperties::LEVEL) != Some(0) {
            return None;
        }

        let air = REGISTRY.blocks.get_default_state_id(&vanilla_blocks::AIR);
        if world.set_block_if_unchanged(pos, state, air, UpdateFlags::UPDATE_ALL_IMMEDIATE)
            != ConditionalBlockSetResult::Changed
        {
            return None;
        }

        let bucket = if is_water_fluid(self.fluid) {
            &vanilla_items::WATER_BUCKET
        } else {
            &vanilla_items::LAVA_BUCKET
        };

        let sound = if is_water_fluid(self.fluid) {
            &sound_events::ITEM_BUCKET_FILL
        } else {
            &sound_events::ITEM_BUCKET_FILL_LAVA
        };

        Some(PickupResult {
            filled_bucket: ItemStack::new(bucket),
            sound: Some(sound),
        })
    }
}

#[cfg(test)]
mod tests {
    use crate::behavior::init_behaviors;
    use steel_registry::{init_vanilla_registry, vanilla_fluids};

    use crate::test_support::TestLevel;

    use super::*;

    #[test]
    fn update_shape_schedules_actual_flowing_fluid_variant() {
        init_vanilla_registry();
        init_behaviors();

        let block = LiquidBlock::new(&vanilla_blocks::WATER, &vanilla_fluids::WATER);
        let state = vanilla_blocks::WATER
            .default_state()
            .set_value(&BlockStateProperties::LEVEL, 1);
        let neighbor_state = vanilla_blocks::WATER.default_state();
        let level = TestLevel::default();

        let updated = block.update_shape(
            state,
            &level,
            BlockPos::ZERO,
            Direction::North,
            Direction::North.relative(BlockPos::ZERO),
            neighbor_state,
        );

        assert_eq!(updated, state);
        assert_eq!(
            level
                .scheduled_fluid_ticks
                .borrow()
                .iter()
                .map(|tick| (tick.fluid, tick.delay))
                .collect::<Vec<_>>(),
            vec![(&vanilla_fluids::FLOWING_WATER, 5)]
        );
    }

    #[test]
    fn source_water_above_soul_sand_schedules_bubble_column_tick() {
        init_vanilla_registry();
        init_behaviors();

        let block = LiquidBlock::new(&vanilla_blocks::WATER, &vanilla_fluids::WATER);
        let state = vanilla_blocks::WATER.default_state();
        let level = TestLevel::default();

        let updated = block.update_shape(
            state,
            &level,
            BlockPos::ZERO,
            Direction::Down,
            BlockPos::ZERO.below(),
            vanilla_blocks::SOUL_SAND.default_state(),
        );

        assert_eq!(updated, state);
        assert!(
            level
                .scheduled_block_ticks
                .borrow()
                .iter()
                .any(|tick| tick.block == &vanilla_blocks::WATER && tick.delay == 20)
        );
    }

    #[test]
    fn flowing_water_does_not_schedule_bubble_column_tick() {
        init_vanilla_registry();
        init_behaviors();

        let block = LiquidBlock::new(&vanilla_blocks::WATER, &vanilla_fluids::WATER);
        let state = vanilla_blocks::WATER
            .default_state()
            .set_value(&BlockStateProperties::LEVEL, 1);
        let level = TestLevel::default();

        let updated = block.update_shape(
            state,
            &level,
            BlockPos::ZERO,
            Direction::Down,
            BlockPos::ZERO.below(),
            vanilla_blocks::SOUL_SAND.default_state(),
        );

        assert_eq!(updated, state);
        assert!(level.scheduled_block_ticks.borrow().is_empty());
    }
}